Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create 2024 content year and make CPO announcement blog post live #874

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

AndraMeer
Copy link
Contributor

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jun 10, 2024

Deploying blog-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2ebb57
Status: ✅  Deploy successful!
Preview URL: https://930fe814.blog-site-602.pages.dev
Branch Preview URL: https://andram-cpo-announcement.blog-site-602.pages.dev

View logs

@AndraMeer AndraMeer marked this pull request as ready for review June 11, 2024 15:55
- "Company Updates"
tag:
- "News"
- "MaxMind team"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of our tags and categories on other posts use title casing. Is this intentionally not title cased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not intentional, the only intentional casing is in the byline. I can adjust this one to say MaxMind Team, thanks Dallas!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case has been adjusted @dhogan8 thank you!

title: "MaxMind appoints seasoned data science leader Rupert Young as Chief Product Officer"
date: "2024-06-11"
images:
- /images/2024/06/rupert_blog.png
Copy link
Contributor

@dhogan8 dhogan8 Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file itself is pretty large (665KB), is there a way to compress it the convert the file type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check with the team!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll compress and update shortly, much appreciated!

Copy link
Contributor

@dhogan8 dhogan8 Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but it may also be worth compressing opmc-maxmind-ecommerce-plugin-partnership.png, which is 6.23MB.

Of course only if its quick and easy to do.

Copy link
Contributor Author

@AndraMeer AndraMeer Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this blog post image has been compressed, and I've passed along the other image compression request. Thanks @dhogan8

Copy link
Contributor Author

@AndraMeer AndraMeer Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPMC image has been compressed, I'll create a separate PR for it sometime today and will swap out the image.

@@ -2,12 +2,12 @@
title: "MaxMind appoints seasoned data science leader Rupert Young as Chief Product Officer"
date: "2024-06-11"
images:
- /images/2024/06/rupert_blog.png
- /images/2024/06/rupert-young-cpo.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we just need to add this image to the repo
Screenshot 2024-06-11 at 1 18 43 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry! i thought i did, i followed the same steps as before. let me see where I went wrong....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes i missed the change from png to jpg, my apologies, thank you for being so patient with me, the n00b (LOL is that still a thing...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I get this stuff is tricky so always happy to help!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like rupert-young-cpo.jpg still needs to be added to the repo though.

Copy link
Contributor

@dhogan8 dhogan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making those changes!

@AndraMeer AndraMeer merged commit 0480fc1 into main Jun 11, 2024
9 checks passed
@AndraMeer AndraMeer deleted the andram/CPO-announcement branch June 11, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants