-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create 2024 content year and make CPO announcement blog post live #874
Conversation
Deploying blog-site with
|
Latest commit: |
a2ebb57
|
Status: | ✅ Deploy successful! |
Preview URL: | https://930fe814.blog-site-602.pages.dev |
Branch Preview URL: | https://andram-cpo-announcement.blog-site-602.pages.dev |
- "Company Updates" | ||
tag: | ||
- "News" | ||
- "MaxMind team" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of our tags and categories on other posts use title casing. Is this intentionally not title cased?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not intentional, the only intentional casing is in the byline. I can adjust this one to say MaxMind Team, thanks Dallas!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
case has been adjusted @dhogan8 thank you!
title: "MaxMind appoints seasoned data science leader Rupert Young as Chief Product Officer" | ||
date: "2024-06-11" | ||
images: | ||
- /images/2024/06/rupert_blog.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file itself is pretty large (665KB), is there a way to compress it the convert the file type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check with the team!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll compress and update shortly, much appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but it may also be worth compressing opmc-maxmind-ecommerce-plugin-partnership.png
, which is 6.23MB.
Of course only if its quick and easy to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this blog post image has been compressed, and I've passed along the other image compression request. Thanks @dhogan8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPMC image has been compressed, I'll create a separate PR for it sometime today and will swap out the image.
@@ -2,12 +2,12 @@ | |||
title: "MaxMind appoints seasoned data science leader Rupert Young as Chief Product Officer" | |||
date: "2024-06-11" | |||
images: | |||
- /images/2024/06/rupert_blog.png | |||
- /images/2024/06/rupert-young-cpo.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry! i thought i did, i followed the same steps as before. let me see where I went wrong....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes i missed the change from png to jpg, my apologies, thank you for being so patient with me, the n00b (LOL is that still a thing...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, I get this stuff is tricky so always happy to help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like rupert-young-cpo.jpg
still needs to be added to the repo though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for making those changes!
No description provided.