Merge pull request #1051 from maxmind/kevin/man-confusion

Harden npm
maxmind · Oct 23, 2023 · aad8763 · aad8763
2 parents 3033984 + 6aa55a1
commit aad8763
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/production.yml b/.github/workflows/production.yml
@@ -57,7 +57,7 @@ jobs:
 
       - if: steps.cache-node-modules.outputs.cache-hit != 'true'
         name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Get cached build
         id: cached-build

diff --git a/.github/workflows/staging.yml b/.github/workflows/staging.yml
@@ -53,7 +53,7 @@ jobs:
 
       - if: steps.cache-node-modules.outputs.cache-hit != 'true'
         name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Get cached build
         id: cached-build

diff --git a/.npmrc b/.npmrc
@@ -1 +1,2 @@
+engine-strict=true
 legacy-peer-deps=true
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -149,7 +149,8 @@
     "xml2js": "^0.5.0"
   },
   "engines": {
-    "node": ">=18"
+    "node": ">=18",
+    "npm": ">=9"
   },
   "license": "MIT",
   "lint-staged": {