-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update several ISP names #1213
Update several ISP names #1213
Conversation
Deploying dev-site with Cloudflare Pages
|
content/geoip/release-notes/2024.md
Outdated
| `Pit Colombia SAS` | `Pit Colombia` | | ||
| `Pit Honduras S. De R.l. De C.v.` | `Pit Honduras S. De R.l.` | | ||
|
||
The following products and services will be effected: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't "effected" be "affected"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either is technically correct in this context. both words can be either a noun or a verb. i always forget which one is preferred because in an academic humanities background "affect" means something very different from "effect" and the distinction persists depending on usage regardless of whether it's a noun or a verb.
i do think "affected" is probably preferred for this context and audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick grammar question, otherwise everything looks good
Continued work to remove unnecessary business tags to ISP names.