Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several ISP names #1213

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Update several ISP names #1213

merged 3 commits into from
Oct 15, 2024

Conversation

christophermluna
Copy link
Contributor

Continued work to remove unnecessary business tags to ISP names.

Copy link

cloudflare-workers-and-pages bot commented Oct 15, 2024

Deploying dev-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd181b
Status: ✅  Deploy successful!
Preview URL: https://37a3b99e.dev-site-4ua.pages.dev
Branch Preview URL: https://luna-isp-name-changes.dev-site-4ua.pages.dev

View logs

| `Pit Colombia SAS` | `Pit Colombia` |
| `Pit Honduras S. De R.l. De C.v.` | `Pit Honduras S. De R.l.` |

The following products and services will be effected:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "effected" be "affected"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either is technically correct in this context. both words can be either a noun or a verb. i always forget which one is preferred because in an academic humanities background "affect" means something very different from "effect" and the distinction persists depending on usage regardless of whether it's a noun or a verb.

i do think "affected" is probably preferred for this context and audience.

Copy link
Contributor

@rajnihatti rajnihatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick grammar question, otherwise everything looks good

@christophermluna christophermluna merged commit a066a8b into main Oct 15, 2024
6 checks passed
@christophermluna christophermluna deleted the luna/isp-name-changes branch October 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants