Add fuzzing support in libmaxminddb #357
Open
+85
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun <pkillarjun@protonmail.com>
horgh
requested changes
Nov 7, 2024
| if (status == MMDB_SUCCESS) | ||
| MMDB_close(&mmdb); | ||
|
|
||
| unlink(filename); |
There was a problem hiding this comment.
Would we want to error check any of these calls? This one, fwrite, fclose, sprintf could all have their return values checked I think.
There was a problem hiding this comment.
This one, fwrite, fclose, sprintf could all have their return values checked I think.
Good idea, but too much voodoo, I guess.
|
|
||
| fp = fopen(filename, "wb"); | ||
| if (!fp) | ||
| return 0; |
There was a problem hiding this comment.
Should this or the above return something other than 0?
There was a problem hiding this comment.
Should this or the above return something other than 0?
No, if the program returns anything else other than return 0;, the coverage won't be counted.
I get it; we could use return -1; or return 1;, but I would say let's keep it return 0; for consistency.
Souce LibFuzzer
Signed-off-by: Arjun <pkillarjun@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuzz_mmdbfuzz target.These are the bugs i found #356
My plans are to integrate libmaxminddb into OSS-Fuzz.