Merge pull request #173 from maxmind/greg/fix-user-agent

Fix handling of user_agent from array
maxmind · May 2, 2024 · 59a45c6 · 59a45c6
2 parents 3ad51f5 + d7e7f55
commit 59a45c6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 CHANGELOG
 =========
 
+3.0.1 (2024-05-02)
+------------------
+
+* When calling `withDevice` with an array, an exception was incorrectly
+  thrown if `user_agent` was set but `session_id` was not set. Reported by
+  Gregor Kuhlmann. GitHub #172.
+
 3.0.0 (2024-04-16)
 ------------------
 

diff --git a/src/MinFraud.php b/src/MinFraud.php
@@ -213,9 +213,7 @@ public function withDevice(
                     $sessionId = (string) $v;
                 }
             }
-            if ($sessionId) {
-                $userAgent = $this->remove($values, 'user_agent');
-            }
+            $userAgent = $this->remove($values, 'user_agent');
 
             $this->verifyEmpty($values);
         }

diff --git a/tests/MaxMind/Test/MinFraudTest.php b/tests/MaxMind/Test/MinFraudTest.php
@@ -380,6 +380,17 @@ public function testMissingIpAddressWithoutValidation(string $class, string $ser
         );
     }
 
+    /**
+     * @dataProvider services
+     */
+    public function testUserAgentWithoutSessionId(string $class, string $service): void
+    {
+        $this->createMinFraudRequestWithFullResponse(
+            $service,
+            request: ['device' => ['user_agent' => 'test']],
+        )->withDevice(['user_agent' => 'test'])->{$service}();
+    }
+
     /**
      * @dataProvider withMethods
      */