Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pairtools merge #1067

Merged
merged 16 commits into from
Oct 11, 2024
Merged

Pairtools merge #1067

merged 16 commits into from
Oct 11, 2024

Conversation

WardDeb
Copy link
Member

@WardDeb WardDeb commented Oct 9, 2024 •
edited
Loading

  • v3.0.1
  • python 3.13 installation test
  • minor docs changes for makePairs
  • docs conf.py fix for latest sphinx
  • bulk makePairs mode up to mcool generation, including mqcs
  • previous allelic makePairs mode moved to 'makePairs_allelic' rule file.
  • conda-recipe has an non-inclusive upper bound for 3.13, at least until conda build works w 3.13
  • Increased verbosity in createEnvs (prints actual conda create command now)
  • included some news (for 3.0.0 as well)

Closes #1026

@WardDeb WardDeb requested a review from katsikora October 9, 2024 19:16
katsikora
katsikora reviewed Oct 11, 2024
View reviewed changes
Copy link
Contributor

@katsikora katsikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ward, thanks for your PR! All looks good, I was just wondering if minor version should be bumped to 3.1.0, due to the added functionality in the pairtools workflow . What do you say?

@WardDeb
Copy link
Member Author

WardDeb commented Oct 11, 2024

Thx ! Agreed with 3.1.0 👍🏼

@WardDeb WardDeb merged commit 55e560b into develop Oct 11, 2024
110 checks passed
@WardDeb WardDeb deleted the pairtools_merge branch October 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katsikora katsikora katsikora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WardDeb @katsikora