fix: do not allow non C-contiguous buffer #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were not allowed in the C-extension but given a bug exists in PyPy, they could be accepted and return the wrong result. Add a workaround for the PyPy bug and disallow non C-contiguous buffer in the pure python fallback implementation. The `encodebytes` buffer check is also a bit stricter in the C-extension to mimic CPython behavior.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
+ Coverage 93.18% 93.57% +0.39%
==========================================
Files 8 8
Lines 1012 1059 +47
Branches 272 285 +13
==========================================
+ Hits 943 991 +48
+ Misses 36 35 -1
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were not allowed in the C-extension but given a bug exists in PyPy, they could be accepted and return the wrong result.
Add a workaround for the PyPy bug and disallow non C-contiguous buffer in the pure python fallback implementation.
The
encodebytesbuffer check is also a bit stricter in the C-extension to mimic CPython behavior.