✨ [#142] Allow registering custom exception handlers in exce…#145
✨ [#142] Allow registering custom exception handlers in exce…#145
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 67.51% 67.50% -0.01%
==========================================
Files 84 84
Lines 3272 3293 +21
Branches 368 375 +7
==========================================
+ Hits 2209 2223 +14
- Misses 970 973 +3
- Partials 93 97 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielmursa-dev
left a comment
There was a problem hiding this comment.
You can test it in objects-api by installing the dependency
In base.in commonground-api-common[oas] -> git+https://github.com/maykinmedia/commonground-api-common.git@feature/142-exception-handler-mapping[oas]
stevenbal
left a comment
There was a problem hiding this comment.
Looks good overall 👍
Could you also make a PR in for instance objects API where you pin commonground-api-common to this branch and use the new functions to register the handlers?
dcdff6d to
4000351
Compare
28ac3d5 to
5d4d103
Compare
f99b9c8 to
785835d
Compare
|
8a89bbf to
2b0a784
Compare
3b5531b to
b30f9e1
Compare
Closes #142