Skip to content

✨ [#142] Allow registering custom exception handlers in exce…#145

Merged
stevenbal merged 3 commits intomainfrom
feature/142-exception-handler-mapping
Feb 3, 2026
Merged

✨ [#142] Allow registering custom exception handlers in exce…#145
stevenbal merged 3 commits intomainfrom
feature/142-exception-handler-mapping

Conversation

@OlhaZahoruiko
Copy link

@OlhaZahoruiko OlhaZahoruiko commented Jan 20, 2026

Closes #142

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 77.58621% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.50%. Comparing base (9cf4333) to head (6d2a8e9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
vng_api_common/exception_handling.py 76.78% 6 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   67.51%   67.50%   -0.01%     
==========================================
  Files          84       84              
  Lines        3272     3293      +21     
  Branches      368      375       +7     
==========================================
+ Hits         2209     2223      +14     
- Misses        970      973       +3     
- Partials       93       97       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OlhaZahoruiko OlhaZahoruiko marked this pull request as ready for review January 20, 2026 15:13
Copy link

@danielmursa-dev danielmursa-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test it in objects-api by installing the dependency

In base.in commonground-api-common[oas] -> git+https://github.com/maykinmedia/commonground-api-common.git@feature/142-exception-handler-mapping[oas]

@OlhaZahoruiko OlhaZahoruiko requested review from stevenbal and removed request for stevenbal January 21, 2026 09:54
Copy link

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍

Could you also make a PR in for instance objects API where you pin commonground-api-common to this branch and use the new functions to register the handlers?

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/142-exception-handler-mapping branch 2 times, most recently from dcdff6d to 4000351 Compare January 26, 2026 09:40
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/142-exception-handler-mapping branch 2 times, most recently from 28ac3d5 to 5d4d103 Compare January 26, 2026 11:29
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/142-exception-handler-mapping branch from f99b9c8 to 785835d Compare January 26, 2026 14:38
@OlhaZahoruiko
Copy link
Author

Looks good overall 👍

Could you also make a PR in for instance objects API where you pin commonground-api-common to this branch and use the new functions to register the handlers?

maykinmedia/objects-api#723

@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/142-exception-handler-mapping branch from 8a89bbf to 2b0a784 Compare January 27, 2026 12:04
@OlhaZahoruiko OlhaZahoruiko force-pushed the feature/142-exception-handler-mapping branch from 3b5531b to b30f9e1 Compare February 3, 2026 09:01
Copy link

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevenbal stevenbal merged commit 734db35 into main Feb 3, 2026
9 checks passed
@stevenbal stevenbal deleted the feature/142-exception-handler-mapping branch February 3, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow defining a mapping of exceptions to responses for exception_handler

4 participants