Skip to content

♻️ [#147] Migrate from setup.cfg to pyproject.toml#150

Merged
stevenbal merged 10 commits intomainfrom
feature/147-migrate-setup.cfg
Feb 19, 2026
Merged

♻️ [#147] Migrate from setup.cfg to pyproject.toml#150
stevenbal merged 10 commits intomainfrom
feature/147-migrate-setup.cfg

Conversation

@danielmursa-dev
Copy link

@danielmursa-dev danielmursa-dev commented Feb 18, 2026

Fixes #147
Migrate from setup.cfg to pyproject.toml

  • migrate ruff
  • migrate bump-my-version
  • create CLI for commonground-api-common generate_schema
  • drop python 3.10 and django4.2
  • set min python3.11 and django5.2

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (83160a1) to head (43f07c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
- Coverage   67.50%   66.66%   -0.85%     
==========================================
  Files          84       89       +5     
  Lines        3293     3417     +124     
  Branches      375      383       +8     
==========================================
+ Hits         2223     2278      +55     
- Misses        973     1044      +71     
+ Partials       97       95       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielmursa-dev danielmursa-dev force-pushed the feature/147-migrate-setup.cfg branch from 1ffc804 to f23aaec Compare February 18, 2026 14:22
@danielmursa-dev
Copy link
Author

danielmursa-dev commented Feb 18, 2026

@stevenbal Should I also create a separate CLI command for generate_notifications_api_spec or fix generate_schema so that it uses both in base of the parameters?

@danielmursa-dev danielmursa-dev force-pushed the feature/147-migrate-setup.cfg branch 2 times, most recently from 509829b to 4d76be9 Compare February 18, 2026 14:30
@danielmursa-dev danielmursa-dev force-pushed the feature/147-migrate-setup.cfg branch from 4d76be9 to 3d6a5ce Compare February 18, 2026 14:33
@danielmursa-dev danielmursa-dev force-pushed the feature/147-migrate-setup.cfg branch 2 times, most recently from 8fba9cd to bf8ea3e Compare February 18, 2026 14:55


@app.command(name="generate_schema")
def generate_schema(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if this command is used in any projects? I think all of them directly run the spectacular command already. If no projects use it, let's remove it altogether

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, checked, and all projects use bin/generate_schema.sh to generate the schema, but this file is overwritten in each project with the project script in bin dir, so it's never actually used.

The same for this one generate_notifications_api_spec.sh

I'll remove both.

@danielmursa-dev danielmursa-dev force-pushed the feature/147-migrate-setup.cfg branch from bf8ea3e to 43f07c5 Compare February 19, 2026 13:16
@stevenbal stevenbal merged commit 7f350c4 into main Feb 19, 2026
6 checks passed
@stevenbal stevenbal deleted the feature/147-migrate-setup.cfg branch February 19, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from setup.cfg / setup.py to pyproject.toml

3 participants