♻️ [#147] Migrate from setup.cfg to pyproject.toml#150
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 67.50% 66.66% -0.85%
==========================================
Files 84 89 +5
Lines 3293 3417 +124
Branches 375 383 +8
==========================================
+ Hits 2223 2278 +55
- Misses 973 1044 +71
+ Partials 97 95 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ffc804 to
f23aaec
Compare
|
@stevenbal Should I also create a separate CLI command for |
509829b to
4d76be9
Compare
4d76be9 to
3d6a5ce
Compare
8fba9cd to
bf8ea3e
Compare
vng_api_common/cli.py
Outdated
|
|
||
|
|
||
| @app.command(name="generate_schema") | ||
| def generate_schema( |
There was a problem hiding this comment.
Could you check if this command is used in any projects? I think all of them directly run the spectacular command already. If no projects use it, let's remove it altogether
There was a problem hiding this comment.
Yes, checked, and all projects use bin/generate_schema.sh to generate the schema, but this file is overwritten in each project with the project script in bin dir, so it's never actually used.
The same for this one generate_notifications_api_spec.sh
I'll remove both.
bf8ea3e to
43f07c5
Compare
Fixes #147
Migrate from
setup.cfgtopyproject.toml