Closed
Conversation
danielmursa-dev
force-pushed
the
ticket-474-fix-version-number
branch
from
6775aa0 to
3c5824f
Compare
Contributor
|
#476 was merged, so if you rebase on master, the check OAF version action should now pass |
stevenbal
requested changes
Nov 29, 2024
src/objects/conf/production.py
Outdated
|
|
||
| from .base import * # noqa isort:skip | ||
|
|
||
| os.environ.setdefault("RELEASE", API_VERSION) |
Collaborator
There was a problem hiding this comment.
API_VERSION is the version of the API endpoint itself and we want to show the version of the application in the admin. This should be the RELEASE setting defined in open-api-framework https://github.com/maykinmedia/open-api-framework/blob/main/open_api_framework/conf/base.py#L640. I'm not sure why it isn't picked up here though, maybe it's not being set in the Docker image?
danielmursa-dev
force-pushed
the
ticket-474-fix-version-number
branch
from
5c8c3b6 to
407b61f
Compare
danielmursa-dev
force-pushed
the
ticket-474-fix-version-number
branch
from
932ab19 to
737bdd4
Compare
danielmursa-dev
force-pushed
the
ticket-474-fix-version-number
branch
from
075189e to
fc58ab5
Compare
This reverts commit 920f139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #474
Fixes maykinmedia/open-api-framework#82
The version number is already correctly set up in open-api-framework, but in objects-api PROD was not configured, so the change is to set the value of the environment variables ‘RELEASE’ with the value from api.py