Skip to content

Issue/570 remove geo widget#581

Merged
Floris272 merged 3 commits intomasterfrom
issue/570-remove-geo-widget
May 9, 2025
Merged

Issue/570 remove geo widget#581
Floris272 merged 3 commits intomasterfrom
issue/570-remove-geo-widget

Conversation

@Floris272
Copy link
Contributor

@Floris272 Floris272 commented May 6, 2025

Fixes #570

Changes

  • removes geodadminMixin & sets the widget for geometry fields to TextArea
  • Fixes issue added in ✨ [#550] Add cache to retrieve versions of objecttypes #571
    • check_objecttype_cached from core/utils is called in by the admin & the api, the errors return "non_field_errors" as the key, which DRF uses by default.
    • The admin however only allows fields of the model or "__all__".

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (524f40a) to head (edb2038).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         147      147           
  Lines        5113     5119    +6     
=======================================
+ Hits         4840     4846    +6     
  Misses        273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Floris272 Floris272 force-pushed the issue/570-remove-geo-widget branch from e8a6db5 to c9831b3 Compare May 6, 2025 13:40
@Floris272 Floris272 marked this pull request as ready for review May 6, 2025 13:41
@Floris272 Floris272 marked this pull request as draft May 8, 2025 13:46
@Floris272 Floris272 force-pushed the issue/570-remove-geo-widget branch from 4b065c3 to c9a248d Compare May 8, 2025 13:56
@Floris272 Floris272 marked this pull request as ready for review May 8, 2025 14:02
@Floris272 Floris272 force-pushed the issue/570-remove-geo-widget branch from c9a248d to edb2038 Compare May 9, 2025 09:08
@Floris272 Floris272 merged commit 5c3aa70 into master May 9, 2025
22 checks passed
@Floris272 Floris272 deleted the issue/570-remove-geo-widget branch May 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geometry in the Objects API admin doesn't seem to work consistently

4 participants