✨ [#586] Replace logging with structlog#594
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 94.69% 94.77% +0.08%
==========================================
Files 148 148
Lines 5142 5164 +22
==========================================
+ Hits 4869 4894 +25
+ Misses 273 270 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevenbal
force-pushed
the
feature/586-add-structlog
branch
5 times, most recently
from
e09cafa to
0c0f375
Compare
stevenbal
force-pushed
the
feature/586-add-structlog
branch
8 times, most recently
from
e171867 to
d67d884
Compare
stevenbal
force-pushed
the
feature/586-add-structlog
branch
from
aa42abc to
fdde828
Compare
the LOGGING settings from OAF have been duplicated to not force all components to use structlog yet, they should be brought back to OAF once Objects API has properly implemented structlog
stevenbal
force-pushed
the
feature/586-add-structlog
branch
from
fdde828 to
ba52edb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
Requires maykinmedia/open-api-framework#138 to be merged/released
Changes