🔧 [#587] added rule to ban import logging#610
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 148 148
Lines 5171 5171
=======================================
Hits 4895 4895
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevenbal
requested changes
May 23, 2025
Collaborator
stevenbal
left a comment
stevenbal
left a comment
There was a problem hiding this comment.
@TimdeBeer1 could you add ruff.toml to the paths for the code-quality workflow? That way it also runs if any changes are made to this file https://github.com/maykinmedia/objects-api/blob/master/.github/workflows/code-quality.yml#L8-L13
TimdeBeer1
force-pushed
the
issue/ban-import-usage-stdlib
branch
3 times, most recently
from
89ca6d8 to
effb46d
Compare
stevenbal
requested changes
May 26, 2025
modified: .github/workflows/code-quality.yml modified: ruff.toml modified: .github/workflows/code-quality.yml modified: ruff.toml modified: src/objects/celery.py modified: src/objects/utils/middleware.py modified: .github/workflows/code-quality.yml modified: ruff.toml modified: src/objects/celery.py modified: src/objects/utils/middleware.py modified: .github/workflows/code-quality.yml modified: ruff.toml modified: src/objects/celery.py modified: src/objects/utils/middleware.py
TimdeBeer1
force-pushed
the
issue/ban-import-usage-stdlib
branch
from
effb46d to
1604c51
Compare
stevenbal
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #587
Changes
Added rule to ban the logging import