Skip to content

🔧 [maykinmedia/open-api-framework#167] Use DB connection pooling settings from OAF#637

Merged
stevenbal merged 1 commit intomasterfrom
issue/oaf-167-pooling-envvar-type-casts
Jul 17, 2025
Merged

🔧 [maykinmedia/open-api-framework#167] Use DB connection pooling settings from OAF#637
stevenbal merged 1 commit intomasterfrom
issue/oaf-167-pooling-envvar-type-casts

Conversation

@stevenbal
Copy link
Collaborator

@stevenbal stevenbal commented Jul 15, 2025

Fixes maykinmedia/open-api-framework#167
Fixes maykinmedia/open-api-framework#166

Changes

  • Use DB connection pooling settings from OAF, also includes fixes for
    • APM not working with connection pooling
    • setting CONN_MAX_AGE to 0 when pooling is enabled
    • type errors for DB_POOLING_MAX_SIZE

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.69%. Comparing base (b191c56) to head (4875192).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   94.70%   94.69%   -0.02%     
==========================================
  Files         149      149              
  Lines        5215     5198      -17     
==========================================
- Hits         4939     4922      -17     
  Misses        276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevenbal stevenbal force-pushed the issue/oaf-167-pooling-envvar-type-casts branch 4 times, most recently from 4d0f613 to a657afc Compare July 17, 2025 10:43
@stevenbal stevenbal changed the title 🐛 [maykinmedia/open-api-framework#167] Fix DB_POOL_MAX_SIZE type error 🔧 [maykinmedia/open-api-framework#167] Use DB connection pooling settings from OAF Jul 17, 2025
also includes fixes for
* APM not working with connection pooling
* setting CONN_MAX_AGE to 0 when pooling is enabled
* type errors for DB_POOLING_MAX_SIZE
@stevenbal stevenbal merged commit 3aad0ef into master Jul 17, 2025
25 checks passed
@stevenbal stevenbal deleted the issue/oaf-167-pooling-envvar-type-casts branch July 17, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants