Skip to content

⬆️ [maykinmedia/open-api-framework#191] upgrade nodejs to v24#693

Merged
stevenbal merged 2 commits intomasterfrom
feature/oaf-191-nodejs-upgrade
Oct 31, 2025
Merged

⬆️ [maykinmedia/open-api-framework#191] upgrade nodejs to v24#693
stevenbal merged 2 commits intomasterfrom
feature/oaf-191-nodejs-upgrade

Conversation

@TimdeBeer1
Copy link
Contributor

@TimdeBeer1 TimdeBeer1 commented Oct 29, 2025

Fixes maykinmedia/open-api-framework#191

Changes

Upgraded nodejs to v24

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.96%. Comparing base (3f7dbce) to head (44f5707).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files         131      131           
  Lines        2488     2488           
  Branches      198      198           
=======================================
  Hits         2089     2089           
  Misses        354      354           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

🐰 Bencher Report

Branchfeature/oaf-191-nodejs-upgrade
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
109.36 ms
(-1.87%)Baseline: 111.44 ms
117.01 ms
(93.46%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
19.44 ms
(-7.03%)Baseline: 20.91 ms
21.96 ms
(88.54%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
267.06 ms
(-1.49%)Baseline: 271.09 ms
284.64 ms
(93.82%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
264.49 ms
(-1.59%)Baseline: 268.76 ms
282.20 ms
(93.72%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
123.10 ms
(-2.90%)Baseline: 126.77 ms
133.11 ms
(92.48%)
🐰 View full continuous benchmarking report in Bencher

@TimdeBeer1 TimdeBeer1 requested a review from stevenbal October 30, 2025 09:50
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the permission form isn't working correctly after the upgrade (/admin/token/permission/<pk>/change/), could you look into this?

afbeelding afbeelding

@TimdeBeer1
Copy link
Contributor Author

It seems that the permission form isn't working correctly after the upgrade (/admin/token/permission/<pk>/change/), could you look into this?
afbeelding afbeelding

In React 18+ ReactDOM.render is deprecated. Now it can be done like this: https://react.dev/reference/react-dom/client/createRoot

@TimdeBeer1 TimdeBeer1 requested a review from stevenbal October 30, 2025 11:44
@stevenbal stevenbal merged commit a54a03d into master Oct 31, 2025
27 checks passed
@stevenbal stevenbal deleted the feature/oaf-191-nodejs-upgrade branch October 31, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade nodejs to >=22 for all components

3 participants