Skip to content

🐛 [maykinmedia/commonground-api-common#134] sentry issue#701

Merged
stevenbal merged 2 commits intomasterfrom
feature/commonground-api-common-134-sentry-issue
Nov 14, 2025
Merged

🐛 [maykinmedia/commonground-api-common#134] sentry issue#701
stevenbal merged 2 commits intomasterfrom
feature/commonground-api-common-134-sentry-issue

Conversation

@TimdeBeer1
Copy link
Contributor

@TimdeBeer1 TimdeBeer1 commented Nov 14, 2025

Fixes maykinmedia/commonground-api-common#134

Changes

Added sentry capture exception to exception handler.

@TimdeBeer1 TimdeBeer1 force-pushed the feature/commonground-api-common-134-sentry-issue branch from 0a0027e to bff837e Compare November 14, 2025 10:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.06%. Comparing base (f52f850) to head (5fddde7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
+ Coverage   84.00%   84.06%   +0.05%     
==========================================
  Files         131      131              
  Lines        2495     2497       +2     
  Branches      199      199              
==========================================
+ Hits         2096     2099       +3     
  Misses        354      354              
+ Partials       45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimdeBeer1 TimdeBeer1 force-pushed the feature/commonground-api-common-134-sentry-issue branch from bff837e to d383508 Compare November 14, 2025 10:17
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

🐰 Bencher Report

Branchfeature/commonground-api-common-134-sentry-issue
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
113.33 ms
(+0.91%)Baseline: 112.32 ms
117.93 ms
(96.10%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
20.90 ms
(+1.28%)Baseline: 20.64 ms
21.67 ms
(96.46%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
267.83 ms
(+0.11%)Baseline: 267.54 ms
280.92 ms
(95.34%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
273.14 ms
(+1.21%)Baseline: 269.87 ms
283.36 ms
(96.39%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
127.21 ms
(+0.22%)Baseline: 126.93 ms
133.28 ms
(95.45%)
🐰 View full continuous benchmarking report in Bencher

@TimdeBeer1 TimdeBeer1 changed the title Feature/commonground api common 134 sentry issue Feature maykinmedia/commonground-api-common#134 sentry issue Nov 14, 2025
@TimdeBeer1 TimdeBeer1 changed the title Feature maykinmedia/commonground-api-common#134 sentry issue Feature [maykinmedia/commonground-api-common#134] sentry issue Nov 14, 2025
@TimdeBeer1 TimdeBeer1 force-pushed the feature/commonground-api-common-134-sentry-issue branch from d383508 to 8f6dfa9 Compare November 14, 2025 10:24
@TimdeBeer1 TimdeBeer1 changed the title Feature [maykinmedia/commonground-api-common#134] sentry issue 🐛 [maykinmedia/commonground-api-common#134] sentry issue Nov 14, 2025
@TimdeBeer1 TimdeBeer1 marked this pull request as ready for review November 14, 2025 10:31
@TimdeBeer1 TimdeBeer1 requested a review from stevenbal November 14, 2025 10:31
@stevenbal stevenbal merged commit 85ed8c6 into master Nov 14, 2025
27 checks passed
@stevenbal stevenbal deleted the feature/commonground-api-common-134-sentry-issue branch November 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exceptions raised in API endpoints are not forwarded to Sentry if DEBUG=False

3 participants