Skip to content

Fix pyproject.toml and factory invocations#714

Merged
CharString merged 3 commits intomasterfrom
chore-fix-factory-annotations
Jan 9, 2026
Merged

Fix pyproject.toml and factory invocations#714
CharString merged 3 commits intomasterfrom
chore-fix-factory-annotations

Conversation

@CharString
Copy link
Contributor

  • [project] table was malformed.
  • New factory boy version has Generic annotations, so .create and .build
    are inferred correctly. This removes the need for that typing.cast

New factory boy version has Generic annotations, so .create and .build
are inferred correctly. This removes the need for typing.cast
`[project]` table was malformed.
@CharString CharString requested a review from Floris272 January 8, 2026 16:41
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.62%. Comparing base (47cde92) to head (e00a5f9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files         138      138           
  Lines        2738     2738           
  Branches      215      215           
=======================================
  Hits         2317     2317           
  Misses        373      373           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

🐰 Bencher Report

Branchchore-fix-factory-annotations
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type📈 view plot
🚷 view threshold
116.12 ms
(-2.48%)Baseline: 119.08 ms
125.04 ms
(92.87%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result📈 view plot
🚷 view threshold
21.26 ms
(-3.40%)Baseline: 22.01 ms
23.11 ms
(92.00%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1📈 view plot
🚷 view threshold
279.00 ms
(-2.38%)Baseline: 285.81 ms
300.10 ms
(92.97%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5📈 view plot
🚷 view threshold
279.25 ms
(-2.45%)Baseline: 286.26 ms
300.57 ms
(92.90%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20📈 view plot
🚷 view threshold
130.38 ms
(-1.23%)Baseline: 132.00 ms
138.60 ms
(94.07%)
🐰 View full continuous benchmarking report in Bencher

Copy link
Contributor

@Floris272 Floris272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did find some remaining direct TokenAuthFactory calls in create_data.py and objects.utils.test

@CharString CharString merged commit 0904770 into master Jan 9, 2026
27 checks passed
@CharString CharString deleted the chore-fix-factory-annotations branch January 9, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants