Skip to content

♻️ [maykinmedia/open-api-framework#175] Add handled_exception#209

Merged
stevenbal merged 1 commit intomasterfrom
feature/improve-exception-handler-with-structlog
Oct 6, 2025
Merged

♻️ [maykinmedia/open-api-framework#175] Add handled_exception#209
stevenbal merged 1 commit intomasterfrom
feature/improve-exception-handler-with-structlog

Conversation

@danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Oct 2, 2025

same as maykinmedia/objects-api#682

Fixes maykinmedia/open-api-framework#175

  • Added structlog event for API HTTP_400_BAD_REQUEST exceptions
  • Fixed error for generic error / exceptions message instead 500 page error

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.17%. Comparing base (47c4fae) to head (f28bb2d).

Files with missing lines Patch % Lines
src/objecttypes/utils/views.py 61.90% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   84.60%   84.17%   -0.43%     
==========================================
  Files          78       78              
  Lines        1091     1112      +21     
  Branches       79       81       +2     
==========================================
+ Hits          923      936      +13     
- Misses        151      158       +7     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from 6fca0d3 to 1932b66 Compare October 2, 2025 13:42
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from 1932b66 to bc9b606 Compare October 2, 2025 13:44
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from bc9b606 to 58160c0 Compare October 6, 2025 07:27
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing

@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from 58160c0 to b93fc32 Compare October 6, 2025 08:01
@danielmursa-dev danielmursa-dev force-pushed the feature/improve-exception-handler-with-structlog branch from b93fc32 to f28bb2d Compare October 6, 2025 08:04
@stevenbal stevenbal merged commit 8c957f9 into master Oct 6, 2025
24 checks passed
@stevenbal stevenbal deleted the feature/improve-exception-handler-with-structlog branch October 6, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logs for error responses should include the error code/detail

3 participants