improve output for error cases in isKeycloakReady #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any thoughts on this, @klg71? |
klg71
approved these changes
Jan 19, 2026
Collaborator
klg71
left a comment
klg71
left a comment
There was a problem hiding this comment.
Sorry I didn't get the notification apparently :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard time debugging why the waitForKeycloak wasn't working anymore locally after updating the version of my keycloak docker container.
It turned out that the base url in my project contained a trailing slash and earlier keycloak versions treated a double slash just like a single one. Newer keycloak versions return a 400 Bad Request instead so the check never completed. And as it didn't run into an exception, an error log every 10th try wasn't coming either.
I hope it's ok the output gets a little more verbose with this change.