Pythonic refactor #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from a JSON file (which has a slightly different format than the hard-coded layerstack, in that it specifies a thickness rather than a zmax)
|
to reduce confusion about the indentation into the new |
|
Great. Are you on the TT discord? What's your handle? |
|
I don't think I'm on tinytapeout discord... my handle on discord is nmz787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using functions instead of a flat structure, paving the way to using alternate triangle generation methods
adding support to load layerstack from JSON format file, which uses 'thickness' instead of zmax (though the JSON loader creates the 'zmax' key and value), since I feel it's a little more intuitive to use the thickness (and closer to something like a process spec).