refactor(loading): move loading to utils.js

mbaraa · May 7, 2024 · b8ce8bb · b8ce8bb
1 parent b60f0e4
commit b8ce8bb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/static/js/player.js b/static/js/player.js
@@ -29,7 +29,6 @@ const playPauseToggleEl = document.getElementById("play"),
   songDurationEl = document.getElementById("song-duration"),
   songCurrentTimeEl = document.getElementById("song-current-time"),
   songImageEl = document.getElementById("song-image"),
-  loadingEl = document.getElementById("loading"),
   audioPlayerEl = document.getElementById("audio-player"),
   muzikkContainerEl = document.getElementById("muzikk");
 
@@ -144,7 +143,7 @@ async function fetchMusic(youtubeId) {
   audioPlayerEl.load();
 }
 
-async function playYTSongById(id, thumbnailUrl, title, artist) {
+async function playYTSong(id, thumbnailUrl, title, artist) {
   const videoData = { id, thumbnailUrl, title, artist };
   await fetchMusic(videoData.id);
   setMediaSession(videoData);
@@ -250,7 +249,7 @@ audioPlayerEl.addEventListener("progress", () => {
 });
 
 window.Player = {
-  playYTSongById,
+  playYTSong,
   showPlayer,
   hidePlayer,
 };
diff --git a/static/js/utils.js b/static/js/utils.js
@@ -1,5 +1,7 @@
 "use strict";
 
+const loadingEl = document.getElementById("loading");
+
 function showLoading() {
   loadingEl.classList.remove("hidden");
 }

diff --git a/views/pages/search_results.templ b/views/pages/search_results.templ
@@ -80,5 +80,5 @@ templ searchResults(results []SearchResult) {
 }
 
 script playSong(id, thumbnailUrl, title, artist string) {
-    window.playYTSongById(id, thumbnailUrl, title, artist);
+    window.Player.playYTSong(id, thumbnailUrl, title, artist);
 }