open via flags for the lib being tested

mbarbin · Oct 31, 2023 · 228aa92 · 228aa92
1 parent 66e84c9
commit 228aa92
Show file tree

Hide file tree

Showing 56 changed files with 67 additions and 95 deletions.
diff --git a/systems/cello/e12/dune b/systems/cello/e12/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_cello_system_e12)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries base fingerboard stdio textutils.ascii_table)
  (inline_tests)
  (preprocess

diff --git a/systems/cello/e12/e12.ml b/systems/cello/e12/e12.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let create () =
   Cello.fifth_system
     ~acoustic_interval:

diff --git a/systems/cello/e12/e12.mli b/systems/cello/e12/e12.mli
@@ -1,3 +1 @@
-open! Fingerboard
-
 val t : System.t Lazy.t
diff --git a/systems/cello/e12/scales.ml b/systems/cello/e12/scales.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale t ~characterized_scale ~from =
   System.make_scale t ~characterized_scale ~from ~to_:Cello.fingerboard_highest_note
 ;;

diff --git a/systems/cello/e12/scales.mli b/systems/cello/e12/scales.mli
@@ -1,4 +1,2 @@
-open! Fingerboard
-
 val lower_c : Located_note.t
 val lower_e_flat : Located_note.t
diff --git a/systems/cello/e12/sixths.ml b/systems/cello/e12/sixths.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_major_scale ~from =
   let t = force E12.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/e12/sixths.mli b/systems/cello/e12/sixths.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/e12/thirds.ml b/systems/cello/e12/thirds.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_major_scale ~from =
   let t = force E12.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/e12/thirds.mli b/systems/cello/e12/thirds.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/e53/dune b/systems/cello/e53/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_cello_system_e53)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries base fingerboard stdio textutils.ascii_table)
  (inline_tests)
  (preprocess

diff --git a/systems/cello/e53/e53.ml b/systems/cello/e53/e53.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let create () =
   Cello.fifth_system
     ~acoustic_interval:

diff --git a/systems/cello/e53/e53.mli b/systems/cello/e53/e53.mli
@@ -1,3 +1 @@
-open! Fingerboard
-
 val t : System.t Lazy.t
diff --git a/systems/cello/e53/scales.ml b/systems/cello/e53/scales.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "edo53 and octaves" =
   let t = force E53.t in
   let az = Cello.find_fingerboard_position_exn t `P8z_e53 in

diff --git a/systems/cello/e53/scales.mli b/systems/cello/e53/scales.mli
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 val lower_c : Located_note.t
 val lower_cp_sharp : Located_note.t
 val lower_dp_flat : Located_note.t

diff --git a/systems/cello/e53/sixths.ml b/systems/cello/e53/sixths.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let adjustment =
   { System.Double_stops.Adjustment.from =
       Acoustic_interval.equal_division_of_the_octave ~divisor:53 ~number_of_divisions:40

diff --git a/systems/cello/e53/sixths.mli b/systems/cello/e53/sixths.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/e53/thirds.ml b/systems/cello/e53/thirds.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let adjustment =
   { System.Double_stops.Adjustment.from =
       Acoustic_interval.equal_division_of_the_octave ~divisor:53 ~number_of_divisions:13

diff --git a/systems/cello/e53/thirds.mli b/systems/cello/e53/thirds.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/e55/dune b/systems/cello/e55/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_cello_system_e55)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries base fingerboard stdio textutils.ascii_table)
  (inline_tests)
  (preprocess

diff --git a/systems/cello/e55/e55.ml b/systems/cello/e55/e55.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let create () =
   Cello.fifth_system
     ~acoustic_interval:

diff --git a/systems/cello/e55/e55.mli b/systems/cello/e55/e55.mli
@@ -1,3 +1 @@
-open! Fingerboard
-
 val t : System.t Lazy.t
diff --git a/systems/cello/e55/scales.ml b/systems/cello/e55/scales.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale t ~characterized_scale ~from =
   System.make_scale t ~characterized_scale ~from ~to_:Cello.fingerboard_highest_note
 ;;

diff --git a/systems/cello/e55/scales.mli b/systems/cello/e55/scales.mli
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 val lower_c : Located_note.t
 val lower_c_sharp : Located_note.t
 val lower_d_flat : Located_note.t

diff --git a/systems/cello/e55/sixths.ml b/systems/cello/e55/sixths.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale ~characterized_scale ~from =
   let t = force E55.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/e55/sixths.mli b/systems/cello/e55/sixths.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/e55/thirds.ml b/systems/cello/e55/thirds.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale ~characterized_scale ~from =
   let t = force E55.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/e55/thirds.mli b/systems/cello/e55/thirds.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/just/dune b/systems/cello/just/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_cello_system_just)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries base fingerboard stdio textutils.ascii_table)
  (inline_tests)
  (preprocess

diff --git a/systems/cello/just/just.ml b/systems/cello/just/just.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let create () = Cello.fifth_system ()
 
 let add_positions t =

diff --git a/systems/cello/just/just.mli b/systems/cello/just/just.mli
@@ -1,3 +1 @@
-open! Fingerboard
-
 val t : System.t Lazy.t
diff --git a/systems/cello/just/scales.ml b/systems/cello/just/scales.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale t ~characterized_scale ~from =
   System.make_scale t ~characterized_scale ~from ~to_:Cello.fingerboard_highest_note
 ;;

diff --git a/systems/cello/just/scales.mli b/systems/cello/just/scales.mli
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 val lower_c : Located_note.t
 val lower_dz_flat : Located_note.t
 val lower_d : Located_note.t

diff --git a/systems/cello/just/sixths.ml b/systems/cello/just/sixths.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let adjustment =
   { System.Double_stops.Adjustment.from =
       Acoustic_interval.pythagorean

diff --git a/systems/cello/just/sixths.mli b/systems/cello/just/sixths.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/just/thirds.ml b/systems/cello/just/thirds.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let adjustment =
   { System.Double_stops.Adjustment.from =
       Acoustic_interval.pythagorean

diff --git a/systems/cello/just/thirds.mli b/systems/cello/just/thirds.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/pythagorean/dune b/systems/cello/pythagorean/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_cello_system_pythagorean)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries base fingerboard stdio textutils.ascii_table)
  (inline_tests)
  (preprocess

diff --git a/systems/cello/pythagorean/pythagorean.ml b/systems/cello/pythagorean/pythagorean.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let create () = Cello.fifth_system ()
 
 let add_positions t =

diff --git a/systems/cello/pythagorean/pythagorean.mli b/systems/cello/pythagorean/pythagorean.mli
@@ -1,3 +1 @@
-open! Fingerboard
-
 val t : System.t Lazy.t
diff --git a/systems/cello/pythagorean/scales.ml b/systems/cello/pythagorean/scales.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale t ~characterized_scale ~from =
   System.make_scale t ~characterized_scale ~from ~to_:Cello.fingerboard_highest_note
 ;;

diff --git a/systems/cello/pythagorean/scales.mli b/systems/cello/pythagorean/scales.mli
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 val lower_c : Located_note.t
 val lower_c_sharp : Located_note.t
 val lower_d_flat : Located_note.t

diff --git a/systems/cello/pythagorean/sixths.ml b/systems/cello/pythagorean/sixths.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale ~characterized_scale ~from =
   let t = force Pythagorean.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/pythagorean/sixths.mli b/systems/cello/pythagorean/sixths.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/systems/cello/pythagorean/thirds.ml b/systems/cello/pythagorean/thirds.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let make_scale ~characterized_scale ~from =
   let t = force Pythagorean.t in
   System.Double_stops.make_scale

diff --git a/systems/cello/pythagorean/thirds.mli b/systems/cello/pythagorean/thirds.mli
@@ -1 +0,0 @@
-open! Fingerboard

diff --git a/test/dune b/test/dune
@@ -1,6 +1,16 @@
 (library
  (name fingerboard_test)
- (flags -w +a-4-40-41-42-44-66 -warn-error +a -open Base -open Stdio)
+ (flags
+  -w
+  +a-4-40-41-42-44-66
+  -warn-error
+  +a
+  -open
+  Base
+  -open
+  Stdio
+  -open
+  Fingerboard)
  (libraries
   base
   fingerboard

diff --git a/test/test__acoustic_interval.ml b/test/test__acoustic_interval.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "first comparison" =
   let module Kind = struct
     type t =

diff --git a/test/test__cello_systems.ml b/test/test__cello_systems.ml
@@ -1,9 +1,9 @@
-open! Fingerboard
 open! Fingerboard_cello_system_e12
 open! Fingerboard_cello_system_e53
 open! Fingerboard_cello_system_just
 open! Fingerboard_cello_system_pythagorean
 
+
 let%expect_test "E12.sexp_of_t" =
   let t = force E12.t in
   print_s [%sexp (t : System.t)];

diff --git a/test/test__fingerboard_position.ml b/test/test__fingerboard_position.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let fingerboard_positions =
   List.map Cello.Fingerboard_position_name.all ~f:(fun t ->
     t, Cello.Fingerboard_position_name.acoustic_interval_to_the_open_string t)

diff --git a/test/test__interval.ml b/test/test__interval.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let qualities number ~doubly_augmented =
   let open Interval.Quality in
   List.concat

diff --git a/test/test__natural_ratio.ml b/test/test__natural_ratio.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "natural_ratio" =
   let ( /^ ) a b = Natural_ratio.create_exn ~numerator:a ~denominator:b in
   let ( // ) = Natural_ratio.divide in

diff --git a/test/test__note.ml b/test/test__note.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "semitons_step" =
   let rec aux start acc index =
     if Note.Letter_name.equal start index && acc > 0

diff --git a/test/test__roman_numeral.ml b/test/test__roman_numeral.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "round-trip" =
   List.iter Roman_numeral.all ~f:(fun n1 ->
     let n2 = n1 |> Roman_numeral.to_int |> Roman_numeral.of_int_exn in

diff --git a/test/test__scale.ml b/test/test__scale.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "major and minor" =
   let major = force Scale.major in
   let minor = force Scale.minor in

diff --git a/test/test__system.ml b/test/test__system.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let test_pitch_exn ~system ~(intervals_going_down : Characterized_interval.t array) =
   (* We test that the pitch is the same for the open string and the position on
      the next vibrating string at the position of the interval between the two

diff --git a/test/test__zarlinean_combination.ml b/test/test__zarlinean_combination.ml
@@ -1,5 +1,3 @@
-open! Fingerboard
-
 let%expect_test "combinations" =
   let all = force Zarlinean_combination.all in
   List.iter all ~f:(fun t -> print_endline (Zarlinean_combination.to_ascii_tables t));