Handle LRAUV log files without GPS data by creating nudged coordinates from dead-reckoned positions#91
Merged
MBARIMike merged 1 commit intombari-org:mainfrom Dec 10, 2025
Merged
Conversation
…s from dead-reckoned positions
Modified combine.py to always create nudged_longitude and nudged_latitude variables,
even when GPS fixes are unavailable. This allows important log files to proceed through
the full processing pipeline (combine → align → resample) to produce _1S.nc files.
Key changes to _add_nudged_coordinates():
- Check for GPS availability before attempting nudging
- Fall back to uncorrected universals_longitude/latitude when GPS is missing or nudging fails
- Add clear warnings in both console logs and metadata attributes
- Include new 'gps_corrected' attribute ("true"/"false") for programmatic detection
When GPS correction cannot be applied:
- Console: WARNING messages alert user during processing
- Metadata: Variable 'comment' includes explicit warning about uncorrected positions
- Metadata: 'gps_corrected' attribute set to "false" for downstream tools to detect
This ensures that scientifically valuable log files (e.g., those with ESP samples) can
be processed even without GPS data, while clearly marking the position data quality
limitations for end users.
Tested with brizo/missionlogs/2025/20250916_20250922/20250920T070029/202509200700_202509201900.nc4
which has no GPS data but successfully processed through to _1S.nc file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified combine.py to always create nudged_longitude and nudged_latitude variables, even when GPS fixes are unavailable. This allows important log files to proceed through the full processing pipeline (combine → align → resample) to produce _1S.nc files.
Key changes to _add_nudged_coordinates():
When GPS correction cannot be applied:
This ensures that scientifically valuable log files (e.g., those with ESP samples) can be processed even without GPS data, while clearly marking the position data quality limitations for end users.
Tested with brizo/missionlogs/2025/20250916_20250922/20250920T070029/202509200700_202509201900.nc4 which has no GPS data but successfully processed through to _1S.nc file.
Kind of still applies to #6