Skip to content

Display seconds in CommsSection timestamps (fixes #491)#509

Merged
ksalamy merged 2 commits intombari-org:developfrom
ksalamy:fix/491-display-seconds-in-log
Feb 12, 2026
Merged

Display seconds in CommsSection timestamps (fixes #491)#509
ksalamy merged 2 commits intombari-org:developfrom
ksalamy:fix/491-display-seconds-in-log

Conversation

@ksalamy
Copy link
Collaborator

@ksalamy ksalamy commented Feb 12, 2026

Extends the full-resolution timestamp display from LogsSection to CommsSection. Command and mission event timestamps now show H:mm:ss for correlation with other datastreams and sources.

Addresses #491.

Extends the full-resolution timestamp display from LogsSection to CommsSection.
Command and mission event timestamps now show H:mm:ss for correlation with
other datastreams and sources.
Copilot AI review requested due to automatic review settings February 12, 2026 19:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends full-resolution timestamp formatting (including seconds) to the CommsSection so comms queue events can be correlated with other time-based data sources, matching the existing behavior in LogsSection.

Changes:

  • Update CommsSection time formatting from H:mm to H:mm:ss for comms event timestamps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 88 to 92
const day = today
? 'Today'
: DateTime.fromISO(item?.commsIsoTime ?? '').toFormat('MMM d yyyy')
const time = DateTime.fromISO(item?.commsIsoTime ?? '').toFormat('H:mm')
const time = DateTime.fromISO(item?.commsIsoTime ?? '').toFormat('H:mm:ss')

Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommsSection has existing component tests, but none assert the rendered timestamp format. Since this change is specifically about showing seconds, please add/extend a test to verify the time text includes seconds (e.g., matches /\d{1,2}:\d{2}:\d{2}/) for a known mocked commsIsoTime value, so regressions don’t slip in unnoticed.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Verifies timestamps include seconds for correlation with other datastreams.
Copy link
Collaborator

@ZackLyon ZackLyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ksalamy ksalamy merged commit e987070 into mbari-org:develop Feb 12, 2026
2 checks passed
@ksalamy ksalamy deleted the fix/491-display-seconds-in-log branch February 12, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants