Take S.H.'s review into account

Apply suggestions from code review Co-authored-by: Sofiane Haddad <sofianehaddad@users.noreply.github.com>
mbaudin47 · May 3, 2024 · 8f87552 · 8f87552
1 parent 8d94f0f
commit 8f87552
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/lib/src/Uncertainty/Algorithm/MetaModel/FunctionalChaos/FunctionalChaosValidation.cxx b/lib/src/Uncertainty/Algorithm/MetaModel/FunctionalChaos/FunctionalChaosValidation.cxx
@@ -2,7 +2,7 @@
 /**
  *  @brief Validation of a functional chaos expansion
  *
- *  Copyright 2005-2023 Airbus-EDF-IMACS-ONERA-Phimeca
+ *  Copyright 2005-2024 Airbus-EDF-IMACS-ONERA-Phimeca
  *
  *  This library is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU Lesser General Public License as published by
@@ -141,7 +141,13 @@ Sample FunctionalChaosValidation::ComputeMetamodelLeaveOneOutPredictions(
   const Point diagonalH = leastSquaresMethod.getHDiag();
   for (UnsignedInteger j = 0; j < outputDimension; ++j)
     for (UnsignedInteger i = 0; i < sampleSize; ++i)
+    {
+      if (diagonalH[i] == 1.0)
+        throw InvalidArgumentException(HERE) 
+          << "The leverage of observation #" << i
+          << " is equal to 1. Cannot divide by zero.";
       cvPredictions(i, j) = outputSample(i, j) - residualsSample(i, j) / (1.0 - diagonalH[i]);
+    } // For observations indices
   return cvPredictions;
 }
 

diff --git a/...c/Uncertainty/Algorithm/MetaModel/FunctionalChaos/openturns/FunctionalChaosValidation.hxx b/...c/Uncertainty/Algorithm/MetaModel/FunctionalChaos/openturns/FunctionalChaosValidation.hxx
@@ -2,7 +2,7 @@
 /**
  *  @brief The validation of a chaos expansion
  *
- *  Copyright 2005-2023 Airbus-EDF-IMACS-ONERA-Phimeca
+ *  Copyright 2005-2024 Airbus-EDF-IMACS-ONERA-Phimeca
  *
  *  This library is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU Lesser General Public License as published by
@@ -48,7 +48,7 @@ public:
   FunctionalChaosValidation();
 
   /** Parameter constructor */
-  FunctionalChaosValidation(const FunctionalChaosResult & chaosResult);
+  explicit FunctionalChaosValidation(const FunctionalChaosResult & chaosResult);
 
   /** Parameter constructor */
   FunctionalChaosValidation(const FunctionalChaosResult & chaosResult,

diff --git a/lib/src/Uncertainty/Algorithm/MetaModel/LinearModel/LinearModelValidation.cxx b/lib/src/Uncertainty/Algorithm/MetaModel/LinearModel/LinearModelValidation.cxx
@@ -2,7 +2,7 @@
 /**
  *  @brief The linear model validation
  *
- *  Copyright 2005-2023 Airbus-EDF-IMACS-ONERA-Phimeca
+ *  Copyright 2005-2024 Airbus-EDF-IMACS-ONERA-Phimeca
  *
  *  This library is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU Lesser General Public License as published by

diff --git a/lib/src/Uncertainty/Algorithm/MetaModel/LinearModel/openturns/LinearModelValidation.hxx b/lib/src/Uncertainty/Algorithm/MetaModel/LinearModel/openturns/LinearModelValidation.hxx
@@ -2,7 +2,7 @@
 /**
  *  @brief The linear model validation
  *
- *  Copyright 2005-2023 Airbus-EDF-IMACS-ONERA-Phimeca
+ *  Copyright 2005-2024 Airbus-EDF-IMACS-ONERA-Phimeca
  *
  *  This library is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU Lesser General Public License as published by
@@ -33,7 +33,7 @@ BEGIN_NAMESPACE_OPENTURNS
 /**
  * @class LinearModelValidation
  *
- * The linear model analysis
+ * The linear model validation
  */
 
 class OT_API LinearModelValidation :
@@ -49,12 +49,12 @@ public:
   explicit LinearModelValidation(const LinearModelResult & linearModelResult);
 
   /** Parameter constructor based on result and leave-one-out */
-  explicit LinearModelValidation(const LinearModelResult & linearModelResult,
-                                 const LeaveOneOutSplitter & splitter);
+  LinearModelValidation(const LinearModelResult & linearModelResult,
+                        const LeaveOneOutSplitter & splitter);
 
   /** Parameter constructor based on result and K-Fold */
-  explicit LinearModelValidation(const LinearModelResult & linearModelResult,
-                                 const KFoldSplitter & splitter);
+  LinearModelValidation(const LinearModelResult & linearModelResult,
+                        const KFoldSplitter & splitter);
 
   /** Virtual constructor */
   LinearModelValidation * clone() const override;