FISTP Fixes + CPU Exception Handling #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrapped `tick()` in Try/Catch to dump CPU state in the event of an exception to help with debugging - Added support for both SS & DS as destination segments for `FISTP` - Additional `FISTP` Unit Tests
paladine
approved these changes
May 3, 2023
MBBSEmu.Tests/CPU/FISTP_Tests.cs
Outdated
| } | ||
|
|
||
| [Theory] | ||
| //[InlineData((double)(long.MaxValue), long.MaxValue, 0)] //Overflows -- need to figure out why |
- `FISTP` on i386/i486 only supports 32-bit Integers, updated code when decompiler incorrectly identifies a 64-bit operation - Added Casting & Conversion Checks setting proper FPU flags on failure
|
Looks like the checks are failing? |
- Handle Logger in Unit Tests (null) - Set CPU ControlWord properly if value from the FPU is larger than a signed 32-bit Integer
|
@paladine This clears all checks now <3 |
paladine
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tick()in Try/Catch to dump CPU state in the event of an exception to help with debuggingFISTPFISTPUnit Tests