Add -DBREBUILD Command #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `-DBREBUILD` command line argument - Add support for rebuilding `BBSUSR.DAT/DB` from the internal MBBSEmu Database
- Move Resetting `BBSUSR` to after loading and verifying internal user records - Refactor `UserAccount` to add constructor to handle data casting, cleans up code
paladine
reviewed
Dec 28, 2023
| /// </summary> | ||
| /// <param name="userName">Username the user will use to log into the system</param> | ||
| /// <param name="userSex">Sex/Gender of the User (Only M/F supported)</param> | ||
| public UserAccount(string userName, char userSex = 'M') : this() |
There was a problem hiding this comment.
probably best to use an enum for userSex parameter to make it a compile time error rather than a runtime error, but not a huge thing
paladine
reviewed
Dec 28, 2023
| @@ -177,6 +187,18 @@ private void Run(string[] args) | |||
|
|
|||
| break; | |||
| } | |||
| case "-DBREBUILD": | |||
There was a problem hiding this comment.
command line parsing is getting crazy. I wrote some cool args/flags parsing code for Java, perhaps I should port it....
paladine
reviewed
Dec 28, 2023
Comment on lines
+694
to
+695
| if (accounts.Count() != _accountBtrieve.GetRecordCount()) | ||
| _logger.Warn($"MBBSEmu Database Account Count ({accounts.Count()}) does not match BBSUSR.DAT Account Count ({_accountBtrieve.GetRecordCount()})"); |
There was a problem hiding this comment.
this likely isn't necessary since Insert should throw if unable to insert a record
paladine
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-DBREBUILDcommand line argumentBBSUSR.DAT/DBfrom the internal MBBSEmu Database