Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Ordinals #629

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Variable Ordinals #629

merged 5 commits into from
Aug 9, 2024

Conversation

enusbaum
Copy link
Member

  • Fix for functions that return strings (or memory pointers) to return unique values for each returned value within a single execution loop
  • Ordinals Reset to 0 on each execution loop, allowing for memory to be reused

- Create Local Variable Tracking Dictionary in Base Class
- Create Helper Methods to get Distinct Variable Names
- Reset Ordinals on each iteration
- Ensure Key Exists before Incrementing
@enusbaum enusbaum requested a review from paladine July 24, 2024 17:02
@enusbaum
Copy link
Member Author

enusbaum commented Aug 9, 2024

Verified that there are only two methods missing unit tests: scanmsg and rawmsg

Upon further investigation, the current scanmsg implementation is incorrect. We only support reading from a MSG file loaded (and defined) in the current module MDF, but the documentation states it should be ANY MSG file.

So we'll need to correct that, I'll open a defect.

@paladine paladine merged commit adc97ac into master Aug 9, 2024
2 checks passed
@paladine paladine deleted the variable-ordinals branch August 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants