Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings from kill and getpid not being implemented #183

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Sep 21, 2023

Summary of changes

Versions of GCC which supply newer Newlib versions (unsure of the exact Newlib version, I think it's the one included with GCC 11 and newer) now appear to want the _getpid() and _kill() functions defined. I checked using radare, and it appears they get pulled in as dependencies of the C++ standard library, which has been built with exception handling enabled and therefore calls things like abort(). So, these warnings will show up whenever someone links an application which uses STL features.

In the long term the best solution is to rebuild the STL with exceptions disabled, or switch to a toolchain which has that done for us, but in the meantime this will stop the warnings from bothering people.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@multiplemonomials multiplemonomials merged commit 36506c9 into master Sep 21, 2023
9 checks passed
@multiplemonomials multiplemonomials deleted the dev/fix-not-implemented-warning branch September 21, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants