Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of CYTFM_064B0S2_4343W #364

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

This PR fixes a couple issues preventing the build of the CYTFM_064B0S2_4343W target:

  • Missing dependency on cysecuretools in requirements.txt prevented the post build script from running
  • The post build script was trying to create and sign tfm_s.hex in the build dir for every target that compiled, so if multiple targets built in parallel, the build would fail with a corrupt file error.
  • Missing dependency on mbed-psa for the MCU target, added this the same as for the Nuvoton target

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Verified that this target now compiles with these fixes


@ccli8
Copy link

ccli8 commented Sep 25, 2024

The post build script was trying to create and sign tfm_s.hex in the build dir for every target that compiled, so if multiple targets built in parallel, the build would fail with a corrupt file error.

Curious about it. Do parallel builds share the same build dir? Then separate build dir will be more meaningful.

@multiplemonomials
Copy link
Collaborator Author

Well, if you compile with e.g. ninja -j4 or make -j4, that could result in up to 4 instances of the post build script running at the same time. If the post build script is trying to manipulate a fixed file path in the build directory, that will cause problems.

@multiplemonomials
Copy link
Collaborator Author

@ccli8 @JohnK1987 good to approve?

@multiplemonomials multiplemonomials merged commit 2f9042f into master Sep 27, 2024
10 checks passed
@multiplemonomials multiplemonomials deleted the dev/fix-cypress-tfm-build branch September 27, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants