Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few CMake issues after the recent upload and memory bank changes #371

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

  • I renamed the GDB_PORT variable but forgot to do a usage search 🤦 🤦 🤦
  • issue Need help on memory_banks.json for custom targets #368 : building without defined memory banks caused a build error because memap.py was looking for memory_banks.json even if it didn't exist

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

(though maybe we need to have some actual testing of the debug configurations, that's how this got in in the first place...)

@multiplemonomials multiplemonomials changed the title Fix a few CMake issues after the recent changes Fix a few CMake issues after the recent upload and memory bank changes Oct 9, 2024
@multiplemonomials multiplemonomials merged commit edf13ff into master Oct 10, 2024
52 checks passed
@multiplemonomials multiplemonomials deleted the dev/fix-some-cmake-issues branch October 10, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants