Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of models_in_same_project_with_same_IDs linter #272

Conversation

lukewoodcock
Copy link
Collaborator

This PR improves usability of models_in_same_project_with_same_IDs

  • remove root directory name entirely from reporting
  • use regex pattern to verify paths to include

This PR also includes removal of some unused dependencies discovered in model org.mpsqa.lint.generic.typesystem in org.mpsqa.lint.generic language

Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked if your way of escaping the backward slashes is ok and the code is actually equivalent to calling PathUtil#toSystemDependentName which you could also use.

@lukewoodcock
Copy link
Collaborator Author

Discussion with @danielratiu, given the importance of model IDs, we decided not to give this functionality to users on the basis we don't want them not checking places they are supposed to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants