Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destination field to AuthnRequest #47

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Add destination field to AuthnRequest #47

merged 2 commits into from
Jul 1, 2023

Conversation

Philonous
Copy link
Contributor

Summary
AuthnRequest has an optional attribute, Destination, which is however required for signed requests. This PR adds this attribute.

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

@github-actions github-actions bot requested a review from mbg June 6, 2023 15:37
mbg
mbg approved these changes Jun 24, 2023
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for adding this ✨

There's just comment about the versioning. Let me know if you want to act on that - otherwise, I am happy to merge this as is and then deal with the versioning issue myself later.

CHANGELOG.md Outdated Show resolved Hide resolved
@mbg mbg merged commit 3ddccb6 into mbg:master Jul 1, 2023
@Philonous
Copy link
Contributor Author

Ah, thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

Assignees

@Philonous Philonous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philonous @mbg