EntityDescriptor: allow multiple certificates in IDPSSODescriptor #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
force-pushed
the
multiple-certificates
branch
from
89bcf67
to
3cd2924
Compare
mbg
reviewed
Jul 19, 2024
| @@ -36,8 +36,8 @@ data IDPSSODescriptor | |||
| = IDPSSODescriptor { | |||
| -- | IdP Entity ID. 'Network.Wai.SAML2.Config.saml2ExpectedIssuer' should be compared against this identifier | |||
| entityID :: Text | |||
| -- | The X.509 certificate for signed assertions | |||
| , x509Certificate :: X509.SignedExact X509.Certificate | |||
| -- | The X.509 certificate for signed assertions -- @since 0.7 | |||
There was a problem hiding this comment.
Minor comment to make certificates plural since there can be several now:
Suggested change
| -- | The X.509 certificate for signed assertions -- @since 0.7 | |
| -- | The X.509 certificates for signed assertions -- @since 0.7 |
There was a problem hiding this comment.
Also, the @since annotation doesn't work at the end of that line -- it has to be on a separate line I think (and possibly separated by an empty comment line)
There was a problem hiding this comment.
Thanks! That seems to work judging by the docs artifacts from the CI runs.
fumieval
force-pushed
the
multiple-certificates
branch
from
3cd2924
to
a15e96a
Compare
fumieval
force-pushed
the
multiple-certificates
branch
from
a15e96a
to
4a0f5f5
Compare
mbg
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I realised that when an IdP is about to rotate their certificates, their IdP metadata may contain more than one certificate.
This PR changes the
x509Certificatetox509Certificates :: [X509.SignedExact X509.Certificate]so that it doesn't drop extra certificates.Checklist
@sinceannotations.