Skip to content

Fix parameter update on stack that had no parameters originally #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

mbj
Copy link
Owner

@mbj mbj commented Apr 1, 2025

No description provided.

@mbj mbj requested a review from Copilot April 1, 2025 02:25
@mbj mbj marked this pull request as ready for review April 1, 2025 02:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the issue with updating a stack's parameters when the stack originally did not have any parameters. It replaces an unsafe unwrap with a match expression to handle the None case gracefully.

  • Replaces the unwrap() call on parameters with a match expression.
  • Uses a BTreeSet with a default empty vector when parameters are absent.

@mbj mbj merged commit 7c7e9cb into main Apr 1, 2025
12 checks passed
@mbj mbj deleted the change/to-unwrap-or-default branch April 1, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant