Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README and fix resource group name default #12

Merged
merged 1 commit into from
May 14, 2024

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented May 13, 2024

No description provided.

Copy link
Collaborator

@dtzar dtzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to bump the chart version and ideally address the one minor doc comment and then LGTM

helm uninstall <name>
```

Note: Uninstall currently is bugged.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this off since you cover the "bugged" below I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note about the AzureClusterIdentity isn't a bug, it's intended to remain after the chart is uninstalled.

@dtzar dtzar merged commit 2cc33f4 into mboersma:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants