Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit client secret from AzureClusterIdentity if value is not set #15

Merged
merged 1 commit into from
May 20, 2024

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented May 20, 2024

No description provided.

@mboersma
Copy link
Owner

Is the chart still functional without clusterIdentitySecretValue? Is it actually optional?

@Jont828
Copy link
Contributor Author

Jont828 commented May 20, 2024

If you don't set that value, it should skip creating the secret so that you can use workload identity. I paired on this with @dtzar last week.

@dtzar dtzar merged commit 540dcdd into mboersma:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants