Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AKS ASO chart #26

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Update AKS ASO chart #26

merged 1 commit into from
Aug 28, 2024

Conversation

dtzar
Copy link
Collaborator

@dtzar dtzar commented Aug 28, 2024 •
edited
Loading

  • Support workload identity
  • Fix clusterclass API errors
  • Improve readme

@dtzar dtzar force-pushed the aksaso-wi branch 3 times, most recently from d0d8af4 to bc8523e Compare August 28, 2024 16:12
@dtzar dtzar requested a review from nojnhuh August 28, 2024 16:13
@dtzar
Copy link
Collaborator Author

dtzar commented Aug 28, 2024 •
edited
Loading

@nojnhuh PodIdentityMode is deprecated and the AUTH_MODE variable defaults to workload identity. AUTH_MODE is also no longer in the public documentation.

@dtzar dtzar force-pushed the aksaso-wi branch 2 times, most recently from 58faf17 to 94e0c9c Compare August 28, 2024 17:48
nojnhuh
nojnhuh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtzar dtzar merged commit c3c4dd0 into mboersma:main Aug 28, 2024
1 check passed
@dtzar dtzar deleted the aksaso-wi branch August 28, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzar @nojnhuh