Skip to content

fix: use all lowercase for authMode #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

rbjorklin
Copy link
Contributor

I'm seeing encountered: authorization mode "workloadIdentity" not valid from here.

The constant in ASO is workloadidentity all in lowercase.

@rbjorklin rbjorklin changed the title fix: use all lower caps for authMode fix: use all lower case for authMode Nov 13, 2024
@rbjorklin rbjorklin changed the title fix: use all lower case for authMode fix: use all lowercase for authMode Nov 13, 2024
Copy link
Owner

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

@mboersma
Copy link
Owner

@rbjorklin could you also update the chart version in charts/azure-aks-aso/Chart.yaml to 0.4.1?

@rbjorklin
Copy link
Contributor Author

@rbjorklin could you also update the chart version in charts/azure-aks-aso/Chart.yaml to 0.4.1?

Done!

@mboersma mboersma merged commit 9724191 into mboersma:main Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants