Add Helm chart for AKS managed cluster #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
mboersma
reviewed
May 7, 2024
mboersma
added
enhancement
|
Some whitespace cleanup required before the linter is happy: |
mboersma
reviewed
May 10, 2024
Jont828
force-pushed
the
aks
branch
3 times, most recently
from
388a898 to
f791b47
Compare
Jont828
changed the title
|
/hold cancel |
mboersma
removed
the
do-not-merge/work-in-progress
Note: this is originated from the following repo: https://github.com/nellyk/azure-managed-cluster-capz-helm Co-authored-by: Nelly Kiboi <3062772+nellyk@users.noreply.github.com> Co-authored-by: Alessandro Vozza <alessandro.vozza@microsoft.com>
dtzar
approved these changes
May 10, 2024
| @@ -0,0 +1 @@ | |||
| *.code-workspace | |||
There was a problem hiding this comment.
Do we want to keep this or perhaps provide a more comprehensive git ignore file on a separate PR?
mboersma
reviewed
May 10, 2024
| defaults: | ||
| agentPool: | ||
| mode: User | ||
| # TODO: should mode be set or required? |
| ## SSH public key (must be valid) | ||
|
|
||
| ## Kubernetes version | ||
| kubernetes_version: "v1.28.5" |
There was a problem hiding this comment.
Suggested change
| kubernetes_version: "v1.28.5" | |
| kubernetes_version: "v1.28.9" |
|
lgtm let's merge this and address any follow-up items in a follow-up PR rapid iteration ftw |
helm repo add capi https://mboersma.github.io/cluster-api-charts
helm install <name> capi/azure-managed-cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Helm chart for AKS managed cluster
Note: this is originated from the following repo: https://github.com/nellyk/azure-managed-cluster-capz-helm
Co-authored-by: Nelly Kiboi 3062772+nellyk@users.noreply.github.com
Co-authored-by: Alessandro Vozza alessandro.vozza@microsoft.com