Skip to content

Fix of the issue "QAbstractSocket::connectToHost() called when already looking up or connecting/connected to xxxx" #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

johnzhanghua
Copy link
Contributor

In the test case networkDownThenUp(). If an network is down and up again, the retry of the connection will get the error "QAbstractSocket::connectToHost() called when already looking up or connecting/connected to xxxx". This will cause the reconnect fail.

Just simply add the socket->abort() after the _q_disconnect will fix the issue.

looking up or connecting/connected to xxxx". When network down and up
again, the connection lost and can not be reconnected.
@mbroadst
Copy link
Owner

mbroadst commented Jun 2, 2016

@johnzhanghua thanks for the contribution! looks like the test is failing though

@johnzhanghua
Copy link
Contributor Author

@mbroadst sorry about the typo, as I use different host, username/password in my test case, just change it to your settings before delivery.

@mbroadst
Copy link
Owner

mbroadst commented Jun 2, 2016

@johnzhanghua great, thanks. Now a final question: is it possible to run this test in less than 5min? That's going to take a somewhat serious toll on continuous integration 😄

@johnzhanghua
Copy link
Contributor Author

@mbroadst , agree it is not a good test case. I might disable the test as you did for the autoReconnect one.

@mbroadst
Copy link
Owner

mbroadst commented Jun 2, 2016

@johnzhanghua I haven't played with the code at all, but it seems like the issue could probably be triggered without having to wait as long. It looks like a test that should indeed be included, but if you don't have much time then I think it might be better moved to a manual test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants