feat(health): add vehicle and prediction state to health checker #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If there almost always are vehicles and predictions, what happens in the rare times when there aren’t? Can we run this in a dev environment for a while? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: ad-hoc
Problem:
During the incident on 10/21 in which the API stopped returning vehicles, we allowed API instances to become healthy with no vehicles. I also noticed that we allow API instances to become healthy with no predictions, whereas there are almost always predictions and vehicles in the API... even at 3AM.
Solution:
Add vehicles and predictions to the API's health check so that new instances with no vehicles cannot join the ALB