feat(LiveComponents.TripPlannerForm): show grouped itineraries from OTP #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
had a problem deploying
to
dev-blue
GitHub Actions
Failure
thecristen
force-pushed
the
cbj/trip-planner-otp
branch
from
c1c93f8
to
caf6c1d
Compare
thecristen
had a problem deploying
to
dev-blue
GitHub Actions
Failure
thecristen
had a problem deploying
to
dev-blue
GitHub Actions
Failure
better luck next time
attempt is made
thecristen
requested review from
joshlarson and
anthonyshull
and removed request for
a team
anthonyshull
reviewed
Oct 3, 2024
| @import 'tailwindcss/components'; | ||
| @import 'tailwindcss/utilities'; | ||
| // MBTA METRO | ||
| @import '../../deps/mbta_metro/priv/static/assets/default.css'; |
anthonyshull
reviewed
Oct 3, 2024
| @valid_modes [:commuter_rail, :subway, :bus, :ferry] | ||
| alias OpenTripPlannerClient.PlanParams | ||
|
|
||
| @valid_modes [:RAIL, :SUBWAY, :BUS, :FERRY] |
There was a problem hiding this comment.
Should alphabetize these. And maybe even use the sigil ~w(BUS FERRY RAIL SUBWAY)a. Not sure if that makes it easier or harder to read.
anthonyshull
approved these changes
Oct 3, 2024
thecristen
merged commit 230781b
into
cbj/trip-planner-input-form
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2173
Summary of changes
Asana Ticket: Trip Planner Preview | Connect input form to OTP and return grouped itineraries
Deployed on dev-blue, it should be able to show itinerary groupings from the Preview trip planner.
Important
Loads up MbtaMetro and makes it workable! The preview trip planner uses several of its components.
Note
Most of the file changes are from 83d068a which migrates us to following best practices for handling static assets! No more copying files from one static folder to another!