refactor(Live.TripPlanner): show form submission while waiting for trips #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/dotcom_web/live/trip_planner.ex
Outdated
Comment on lines
14
to
15
| import MbtaMetro.Components.Feedback | ||
| import MbtaMetro.Components.Spinner |
There was a problem hiding this comment.
Can combine these MbtaMetro.Components.{Feedback, Spinner}.
anthonyshull
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't quite satisfied with the current experience of waiting for results. This change simplies the form code a bit, and lets us show the submitted form details immediately (black text), while showing a spinner until the results are retrieved (status of this is shown below the black text).
It can also show the error code.
The formatting is also adjusted to be closer to the desired output from the Figma mock, though I couldn't figure out how to format dates with suffixes (e.g. October 11th instead of October 11)..