Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkout repo before accessing file. #5

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Oct 7, 2024

Forgot to checkout the repo before access github.workspace.

@cmaddox5 cmaddox5 requested a review from a team as a code owner October 7, 2024 17:28
Copy link
Contributor

@digitalcora digitalcora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difficulty of testing workflows before they're merged strikes again 🙃

I wonder if we should add .github/** to the paths entries. Then for future modifications to (at least) the validation workflow, it can be tested on the branch before merging.

@cmaddox5
Copy link
Contributor Author

cmaddox5 commented Oct 7, 2024

Ooo, I like that idea. Will add to the validation step.

@digitalcora
Copy link
Contributor

If we also add it to the upload step, that would ensure if we commit a change to the workflow, it will redo the upload (and in the process verify that the workflow is still valid and works). Of course, knowing about any problems there before merging an update to the workflow would be ideal... I guess we could also make that workflow executable on dispatch but maybe this is bikeshedding.

@cmaddox5 cmaddox5 merged commit 857b281 into main Oct 8, 2024
1 check passed
@cmaddox5 cmaddox5 deleted the cm/checkout-repo branch October 8, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants