feat:refactor(ts/components/follower): only call onUpdate if not `u…

…ndefined`
mbta · Oct 23, 2023 · e8a1c23 · e8a1c23
1 parent ad4759a
commit e8a1c23
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/assets/src/components/map/follower.tsx b/assets/src/components/map/follower.tsx
@@ -25,7 +25,7 @@ export type UpdateMapFromPointsFn = (map: LeafletMap, points: LatLng[]) => void
 
 export interface FollowerProps {
   positions: LatLng[]
-  onUpdate: UpdateMapFromPointsFn
+  onUpdate?: UpdateMapFromPointsFn
 }
 
 export const Follower = ({
@@ -48,7 +48,7 @@ export const Follower = ({
       if (isAnimatingFollowUpdate !== undefined) {
         isAnimatingFollowUpdate.current = true
       }
-      onUpdate(map, currentLatLngs)
+      onUpdate?.(map, currentLatLngs)
     }
   }, [map, shouldFollow, isAnimatingFollowUpdate, currentLatLngs, onUpdate])
 

diff --git a/assets/src/components/mapPage/mapDisplay.tsx b/assets/src/components/mapPage/mapDisplay.tsx
@@ -321,7 +321,7 @@ const SelectedVehicleDataLayers = ({
       />
       <InterruptibleFollower
         // Do nothing if we don't have a vehicle position yet
-        onUpdate={position.length === 0 ? () => {} : onUpdate}
+        onUpdate={position.length > 0 ? onUpdate : undefined}
         positions={position}
         {...followerState}
         setShouldFollow={(...args) => {