Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detour controller updates for single detour #2795

Merged
merged 16 commits into from
Sep 23, 2024
Merged

feat: Detour controller updates for single detour #2795

merged 16 commits into from
Sep 23, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell commented Sep 13, 2024 •
edited
Loading

I moved around some detour models and added the new detour controller function

Depends on:

@hannahpurcell hannahpurcell requested a review from a team as a code owner September 13, 2024 16:52
@hannahpurcell hannahpurcell mentioned this pull request Sep 13, 2024
Closed
@github-actions GitHub Actions
Copy link

Coverage of commit cc740fb

Summary coverage rate:
  lines......: 93.0% (3326 of 3576 lines)
  functions..: 72.4% (1365 of 1886 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detour.ex                                     | 0.0%      2| 0.0%     2|    -      0
  lib/skate/detours/detours.ex                                    |91.7%     36|81.2%    16|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |98.0%     50|94.1%    17|    -      0

Download coverage report

@joshlarson joshlarson mentioned this pull request Sep 13, 2024
Merged
@github-actions GitHub Actions
Copy link

Coverage of commit 713ba13

Summary coverage rate:
  lines......: 93.0% (3326 of 3576 lines)
  functions..: 72.4% (1365 of 1886 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detour.ex                                     | 0.0%      2| 0.0%     2|    -      0
  lib/skate/detours/detours.ex                                    |91.7%     36|81.2%    16|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |98.0%     50|94.1%    17|    -      0

Download coverage report

@hannahpurcell hannahpurcell mentioned this pull request Sep 19, 2024
Merged
Base automatically changed from hp/reorganize-detour-api-stuff to main September 23, 2024 13:56
@github-actions GitHub Actions
Copy link

Coverage of commit f4e546e

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detour.ex                                     | 0.0%      2| 0.0%     2|    -      0
  lib/skate/detours/detours.ex                                    |86.8%     38|76.5%    17|    -      0
  lib/skate_web/controllers/detours_controller.ex                 |98.0%     50|94.1%    17|    -      0

Download coverage report

@hannahpurcell hannahpurcell merged commit 01fb9ce into main Sep 23, 2024
9 checks passed
@hannahpurcell hannahpurcell deleted the hp/detour-controller-update-for-single-detour branch September 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahpurcell @firestack