Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create detour notification table #2798

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

firestack
Copy link
Member

@firestack firestack commented Sep 18, 2024

Asana Ticket: https://app.asana.com/0/0/1208312289539633/f

Not sure if this PR is too small, but I'm fairly certain this will be the final shape of the table and that could be merged first.

This adds a field to the notifications table, because there were errors if it wasn't added, but it's intended that this table is entirely unused as of this PR, following PRs will use this table.

If this PR is too small I can roll this table creation into a PR that uses it.

@firestack firestack marked this pull request as ready for review September 19, 2024 13:57
@firestack firestack requested a review from a team as a code owner September 19, 2024 13:57
Copy link

Coverage of commit d679f48

Summary coverage rate:
  lines......: 92.5% (3302 of 3571 lines)
  functions..: 71.5% (1365 of 1908 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/notifications/db/detour.ex                                  | 0.0%      3| 0.0%     7|    -      0
  lib/notifications/db/notification.ex                            |66.7%      6|77.8%     9|    -      0

Download coverage report

Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too small! Looks good 👍

@firestack firestack merged commit 591da1c into main Sep 20, 2024
15 checks passed
@firestack firestack deleted the kf/asn/de-not/new-table branch September 20, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants