Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update route ladder dropdown #2802

Merged
merged 9 commits into from
Sep 27, 2024
Merged

feat: Update route ladder dropdown #2802

merged 9 commits into from
Sep 27, 2024

Conversation

hannahpurcell
Copy link
Collaborator

@hannahpurcell hannahpurcell commented Sep 19, 2024 •
edited
Loading

Asana ticket: https://app.asana.com/0/1205385723132845/1208333281632131

Pushing up my current work. I'm again confused by tests; to be fixed when I get back from time off

hannahpurcell and others added 3 commits September 24, 2024 12:32
@hannahpurcell @joshlarson
fix: Tests
d9c703c 
Co-authored-by: Josh Larson <jlarson@mbta.com>
@hannahpurcell
fix: formatting
c10a2b8
@hannahpurcell
fix: Tests, cont'd
a292e27
@hannahpurcell hannahpurcell marked this pull request as ready for review September 25, 2024 14:06
@hannahpurcell hannahpurcell requested a review from a team as a code owner September 25, 2024 14:06
joshlarson
joshlarson requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! I made a few comments about CSS that I'd like to talk about, but don't necessarily need to block approval, and one visual issue that I think would be good fix before merging.

joshlarson
joshlarson approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@joshlarson joshlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because this looks great, and the out-standing CSS questions require a team-wide consensus that doesn't exist yet. Not that they shouldn't be addressed, but I'm not ready to withhold my approval for this feature on it.

@hannahpurcell hannahpurcell merged commit 3eb545e into main Sep 27, 2024
57 checks passed
@hannahpurcell hannahpurcell deleted the hp/update-route-ladder-dropdown branch September 27, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack left review comments

@joshlarson joshlarson joshlarson approved these changes

Assignees

@joshlarson joshlarson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahpurcell @joshlarson @firestack