Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak: Preload author and retrieve detours in one query #2804

Merged
merged 2 commits into from
Sep 23, 2024
Merged

tweak: Preload author and retrieve detours in one query #2804

merged 2 commits into from
Sep 23, 2024

Conversation

hannahpurcell
Copy link
Collaborator

No asana task, adhoc!

@hannahpurcell @firestack
tweak: Fix detours query to do the author preload and detour retrieva…
a810034 
…l in one query

Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
@hannahpurcell hannahpurcell requested a review from a team as a code owner September 23, 2024 16:42
firestack
firestack approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@firestack firestack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 (there are credo things to fix but looks good!)

@github-actions GitHub Actions
Copy link

Coverage of commit e033f87

Summary coverage rate:
  lines......: 92.4% (3309 of 3580 lines)
  functions..: 71.4% (1365 of 1912 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |86.8%     38|76.5%    17|    -      0

Download coverage report

@hannahpurcell hannahpurcell merged commit 0d06ca3 into main Sep 23, 2024
9 checks passed
@hannahpurcell hannahpurcell deleted the hp/update-detour-query branch September 23, 2024 20:45
firestack
firestack reviewed Sep 24, 2024
View reviewed changes
lib/skate/detours/detours.ex

## Examples

iex> list_detours()
[%Detour{}, ...]
"""
def list_detours do
Detour
(detour in Skate.Detours.Db.Detour)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah! I didn't think the macro would allow you to do this :o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firestack firestack firestack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahpurcell @firestack